Skip to content

Reduce log level for skip_verification_paths from WARNING to DEBUG#25

Merged
alexrashed merged 1 commit into
mainfrom
reduce-skip-paths-log-level
Jun 10, 2026
Merged

Reduce log level for skip_verification_paths from WARNING to DEBUG#25
alexrashed merged 1 commit into
mainfrom
reduce-skip-paths-log-level

Conversation

@alexrashed

@alexrashed alexrashed commented Jun 9, 2026

Copy link
Copy Markdown
Member

Motivation

_assert_all() logged at WARNING when skip_verification_paths was provided, but skipping specific paths is a deliberate and common choice - not an unexpected condition.
This leads to polluted logs in our pipelines.
This PR reduces the log level from WARNING to DEBUG so it only surfaces when DEBUG_SNAPSHOT is set.

Testing

Both of these scenarios have been tested by me manually locally:

  • Confirm no WARNING is emitted when skipping specific paths.
  • Confirm the message still appears at DEBUG level when DEBUG_SNAPSHOT is set

Skipping specific snapshot paths is a deliberate, common call-site choice
and not a condition worth surfacing as a warning to all consumers.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@alexrashed alexrashed marked this pull request as ready for review June 9, 2026 15:38
@alexrashed alexrashed requested a review from bblommers June 9, 2026 15:38

@bblommers bblommers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Removing unnecessary details from the logs is always welcome

@alexrashed alexrashed merged commit 936e86f into main Jun 10, 2026
3 checks passed
@alexrashed alexrashed deleted the reduce-skip-paths-log-level branch June 10, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants